Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: remove grpc server max connection age options #2427

Merged
merged 2 commits into from
Aug 3, 2021
Merged

config: remove grpc server max connection age options #2427

merged 2 commits into from
Aug 3, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Remove grpc_server_max_connection_age and grpc_server_max_connection_age_grace.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Aug 3, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner August 3, 2021 15:22
@calebdoxsey calebdoxsey requested a review from wasaga August 3, 2021 15:22
@codeclimate
Copy link

codeclimate bot commented Aug 3, 2021 •
edited
Loading

Code Climate has analyzed commit 80c9b64 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

coveralls commented Aug 3, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 65.231% when pulling 80c9b64 on cdoxsey/448-remove-grpc-settings into 56bbc31 on master.

desimone
desimone approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I did a quick check and this code looks to be inert going back to at least v0.9.X

@calebdoxsey calebdoxsey merged commit 94eb3c1 into master Aug 3, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/448-remove-grpc-settings branch August 3, 2021 15:39
@desimone
Copy link
Contributor

desimone commented Aug 3, 2021

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @desimone