Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove hadolint #2726

Merged
merged 1 commit into from Oct 28, 2021
Merged

Conversation

travisgroth
Copy link
Contributor

Summary

Remove hadolint validation in CI. While the rules are useful in general, we tend to only violate them in transient build containers and often for good reason. The number of lint ignore comments we need to keep CI from being noisy isn't worth it.

Related issues

n/a

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@travisgroth travisgroth requested a review from a team as a code owner October 28, 2021 22:35
@codeclimate
Copy link

codeclimate bot commented Oct 28, 2021

Code Climate has analyzed commit 524897f and detected 0 issues on this pull request.

View more on Code Climate.

@desimone
Copy link
Contributor

Related
#1489
#2363

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 65.008% when pulling 524897f on travisgroth:remove_hadolint into 4d501de on pomerium:master.

@travisgroth travisgroth merged commit c3171ad into pomerium:master Oct 28, 2021
@travisgroth travisgroth deleted the remove_hadolint branch October 28, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants