Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for supported Ingress annotations #3310

Merged
merged 1 commit into from May 5, 2022
Merged

Update docs for supported Ingress annotations #3310

merged 1 commit into from May 5, 2022

Conversation

somerandow
Copy link
Contributor

@somerandow somerandow commented May 1, 2022 •
edited

Signed-off-by: TJ Wesolowski wojoinc@pm.me

Summary

Adds docs for supported annotations introduced by pomerium/ingress-controller#183

Related issues

pomerium/ingress-controller#183
#2979

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@somerandow
Update docs for supported Ingress annotations
e2f5382 
Signed-off-by: TJ Wesolowski <wojoinc@pm.me>
@somerandow somerandow mentioned this pull request May 1, 2022
Merged
6 tasks
@wasaga wasaga requested a review from alexfornuto May 4, 2022 23:39
@wasaga wasaga assigned wasaga and alexfornuto and unassigned wasaga May 4, 2022
alexfornuto
alexfornuto approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review is a 👍. I'd generally prefer a technical review first and have it in the PR for historical purposes. In this case @wasaga confirmed on slack that these annotations were recently added.

@alexfornuto alexfornuto added docs Docs update required backport 0-17-0 labels May 5, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 64.306% when pulling e2f5382 on WojoInc:update_annotation_docs into a5148c3 on pomerium:main.

@alexfornuto
Copy link
Contributor

alexfornuto commented May 5, 2022 •
edited

Thanks for the contribution @WojoInc! I'm assigning this to @wasaga to merge once the new annotations are released.

EDIT: Actually, we'll hold off on the backport until the release.

@alexfornuto alexfornuto assigned wasaga and unassigned alexfornuto May 5, 2022
@alexfornuto alexfornuto merged commit 5fff3c3 into pomerium:main May 5, 2022
backport-actions-token bot pushed a commit that referenced this pull request May 5, 2022
@somerandow @github-actions
Update docs for supported Ingress annotations (#3310)
9a92688 
Signed-off-by: TJ Wesolowski <wojoinc@pm.me>
(cherry picked from commit 5fff3c3)
@backport-actions-token backport-actions-token bot mentioned this pull request May 5, 2022
Merged
wasaga pushed a commit that referenced this pull request May 5, 2022
@backport-actions-token @somerandow
Update docs for supported Ingress annotations (#3310) (#3325)
9e24037 
Signed-off-by: TJ Wesolowski <wojoinc@pm.me>
(cherry picked from commit 5fff3c3)

Co-authored-by: Thomas John Wesolowski <wojoinc@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfornuto alexfornuto alexfornuto approved these changes

Assignees

@wasaga wasaga

Labels
backport 0-17-0 docs Docs update required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@somerandow @coveralls @alexfornuto @wasaga