Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate global events manager #3422

Merged
merged 5 commits into from Jun 14, 2022
Merged

eliminate global events manager #3422

merged 5 commits into from Jun 14, 2022

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Jun 14, 2022 •
edited

Summary

  • Remove global events manager and pass it as argument to New().
  • Hold read lock while dispatching events.
  • Make tests run with -race by default.

Related issues

Fixes cover flakiness in #3415 internal/cmd/pomerium package.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner June 14, 2022 03:05
@wasaga wasaga requested a review from calebdoxsey June 14, 2022 03:05
@coveralls
Copy link

coveralls commented Jun 14, 2022 •
edited

Coverage Status

Coverage increased (+0.5%) to 64.258% when pulling 090734a on wasaga/no-global-events-mgr into 6b386f2 on main.

@wasaga wasaga merged commit db42607 into main Jun 14, 2022
@wasaga wasaga deleted the wasaga/no-global-events-mgr branch June 14, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wasaga @coveralls @calebdoxsey