Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: remove test #3442

Merged
merged 1 commit into from Jun 21, 2022
Merged

cmd: remove test #3442

merged 1 commit into from Jun 21, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

Remove the unit tests from pkg/cmd/pomerium. These tests are flaky. They were testing starting the executable which is better tested via the integration tests. And the tests only seemed to be testing the config parsing.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the ci CI/CD and release automation label Jun 21, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner June 21, 2022 16:00
@calebdoxsey calebdoxsey requested a review from wasaga June 21, 2022 16:00
@calebdoxsey calebdoxsey merged commit 8699e36 into main Jun 21, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/remove-cmd-test branch June 21, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI/CD and release automation NeedsDiscussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants