authorize: add policy error details for custom error messages #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desimone
approved these changes
Aug 9, 2022
| @@ -193,6 +196,9 @@ type SubPolicy struct { | |||
| AllowedDomains []string `mapstructure:"allowed_domains" yaml:"allowed_domains,omitempty" json:"allowed_domains,omitempty"` | |||
| AllowedIDPClaims identity.FlattenedClaims `mapstructure:"allowed_idp_claims" yaml:"allowed_idp_claims,omitempty" json:"allowed_idp_claims,omitempty"` | |||
| Rego []string `mapstructure:"rego" yaml:"rego" json:"rego,omitempty"` | |||
|
|
|||
| Explanation string `mapstructure:"explanation" yaml:"explanation" json:"explanation,omitempty"` | |||
There was a problem hiding this comment.
Worth adding a docstring here to distinguish Remediation and Explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
PolicyEvaluationTracestruct and fill it during policy evaluation. This struct contains fields related to policy evaluation that can be used for better errors.Related issues
Fixes https://github.com/pomerium/internal/issues/949
User Explanation
Not user facing.
Checklist
improvement/bug/ etc)