Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the traces error details #3557

Merged
merged 1 commit into from Aug 16, 2022
Merged

add the traces error details #3557

merged 1 commit into from Aug 16, 2022

Conversation

nhayfield
Copy link
Contributor

@nhayfield nhayfield commented Aug 16, 2022

Summary

Adds error details when appropriate.

Related issues

Fixes https://github.com/pomerium/internal/issues/950

User Explanation

When policy has remediation and explanation attached and the route is set to show error details the ui will reflect this.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@nhayfield nhayfield requested a review from a team as a code owner August 16, 2022 15:52
@nhayfield nhayfield added the enhancement New feature or request label Aug 16, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.257% when pulling 3e6d335 on tracesErrorDetails into dc122bc on main.

@nhayfield nhayfield merged commit 0e73bd3 into main Aug 16, 2022
@nhayfield nhayfield deleted the tracesErrorDetails branch August 16, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants