Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticate: add CORS headers to jwks endpoint #3574

Merged
merged 1 commit into from Aug 25, 2022
Merged

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Aug 25, 2022

Summary

To give any javascript application the ability to query this endpoint, we should add CORS headers.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner August 25, 2022 18:12
@calebdoxsey calebdoxsey added bug Something isn't working backport 0-18-0 labels Aug 25, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 66.35% when pulling 63191f6 on cdoxsey/jwks-cors into e9e52d8 on main.

@calebdoxsey calebdoxsey merged commit 5f51510 into main Aug 25, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/jwks-cors branch August 25, 2022 22:09
@backport-actions-token
Copy link

The backport to 0-18-0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-0-18-0 0-18-0
# Navigate to the new working tree
cd .worktrees/backport-0-18-0
# Create a new branch
git switch --create backport-3574-to-0-18-0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 5f51510e91d3282b386d5893ed4168bf793d8c6f
# Push it to GitHub
git push --set-upstream origin backport-3574-to-0-18-0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-0-18-0

Then, create a pull request where the base branch is 0-18-0 and the compare/head branch is backport-3574-to-0-18-0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-18-0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants