Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocert: fix flaky test #3591

Merged
merged 1 commit into from Aug 30, 2022
Merged

autocert: fix flaky test #3591

merged 1 commit into from Aug 30, 2022

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Aug 30, 2022 •
edited

Summary

This test seems to fail in github actions sometimes. Wasn't able to reproduce locally, but hopefully this should prevent it from happening.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the ci CI/CD and release automation label Aug 30, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner August 30, 2022 14:20
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 66.434% when pulling 1a79881 on cdoxsey/autocert-test into e5ac784 on main.

@calebdoxsey calebdoxsey merged commit 8713108 into main Aug 30, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/autocert-test branch August 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
ci CI/CD and release automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @desimone