Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove forward auth #3628

Merged
merged 2 commits into from Nov 23, 2022
Merged

remove forward auth #3628

merged 2 commits into from Nov 23, 2022

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Sep 19, 2022 •
edited

Summary

Refactor forward auth so it no longer lives in pomerium core.

Related issues

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@coveralls
Copy link

coveralls commented Sep 19, 2022 •
edited

Coverage Status

Coverage decreased (-0.5%) to 63.908% when pulling f4deb94 on cdoxsey/remove-forward-auth into ba07afc on main.

@calebdoxsey calebdoxsey marked this pull request as ready for review November 23, 2022 21:09
@calebdoxsey calebdoxsey requested a review from a team as a code owner November 23, 2022 21:09
@calebdoxsey calebdoxsey added breaking Backward incompatible change in behaviour, api or config enhancement New feature or request labels Nov 23, 2022
desimone
desimone approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 thank you goodbye

@calebdoxsey calebdoxsey merged commit fa26587 into main Nov 23, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/remove-forward-auth branch November 23, 2022 22:59
@branchmispredictor branchmispredictor mentioned this pull request Dec 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

@desimone desimone desimone approved these changes

Assignees
No one assigned
Labels
breaking Backward incompatible change in behaviour, api or config enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebdoxsey @coveralls @wasaga @desimone