Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgres: handle unknown types #3632

Merged
merged 1 commit into from Sep 28, 2022
Merged

postgres: handle unknown types #3632

merged 1 commit into from Sep 28, 2022

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Sep 28, 2022 •
edited

Summary

Currently if an unknown protobuf type is stored in the database listing records will fail with an error. This PR updates the code to ignore unknown types.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner September 28, 2022 15:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 66.558% when pulling 2fc42cf on cdoxsey/postgres-improvements into 95753de on main.

@calebdoxsey calebdoxsey merged commit 3fec00f into main Sep 28, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/postgres-improvements branch September 28, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @wasaga