postgres: return an empty list of addresses on dns errors #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desimone
approved these changes
Sep 30, 2022
calebdoxsey
added a commit
that referenced
this pull request
Sep 30, 2022
postgres: return an empty list of addresses on dns errors (#3637) Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The underlying postgres driver supports multiple failover hosts, but only if the DNS address used for the host resolves to an IP address. This PR changes the lookup function so that it does not return an error if a host doesn't resolve and instead returns an empty list of IP addresses. This in turn allows the multiple host capability to work properly.
Related issues
Fixes #3634
Checklist
improvement/bug/ etc)