Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow blank identity providers when loading sessions for service account support #3709

Merged
merged 1 commit into from Oct 27, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

Service accounts are JWTs with the same format as a sessions.State, except they don't have an identity provider ID. This PR updates the loading code to allow empty identity provider IDs.

Related issues

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Oct 26, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner October 26, 2022 21:56
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 66.357% when pulling 8e55698 on cdoxsey/session-load-service-account into 1b59611 on main.

@calebdoxsey calebdoxsey merged commit 6a9d6e4 into main Oct 27, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/session-load-service-account branch October 27, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants