Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep trace span context #3724

Merged
merged 1 commit into from Nov 4, 2022
Merged

keep trace span context #3724

merged 1 commit into from Nov 4, 2022

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Nov 4, 2022 •
edited

Summary

Do not discard context returned by StartSpan to properly see call hierarchy.

Before

image

After

image

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner November 4, 2022 21:23
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 64.936% when pulling 7171d98 on wasaga/keep-span-context into c178819 on main.

@wasaga wasaga merged commit a3cfe8f into main Nov 4, 2022
@wasaga wasaga deleted the wasaga/keep-span-context branch November 4, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wasaga @coveralls @calebdoxsey