Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: disable Strict-Transport-Security when using a self-signed certificate #3743

Merged
merged 1 commit into from Nov 10, 2022
Merged

config: disable Strict-Transport-Security when using a self-signed certificate #3743

merged 1 commit into from Nov 10, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

Only add the Strict-Transport-Security header by default when we're using a certificate we don't generate. This should prevent annoying HSTS pinning errors.

Related issues

Fixes #3741

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label Nov 10, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner November 10, 2022 21:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 64.961% when pulling e495c35 on cdoxsey/smart-hsts into 01445a8 on main.

@calebdoxsey calebdoxsey merged commit 2c9087f into main Nov 10, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/smart-hsts branch November 10, 2022 23:01
@ZPain8464 ZPain8464 mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quickstart: disable HSTS headers for self-signed certificates
3 participants
@calebdoxsey @coveralls @wasaga