Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpke: add hpke package #3761

Merged
merged 5 commits into from Nov 22, 2022
Merged

hpke: add hpke package #3761

merged 5 commits into from Nov 22, 2022

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Nov 21, 2022 •
edited

Summary

HPKE is hybrid public key encryption. This PR adds a package that can be used for sealing and opening messages using HPKE from the github.com/cloudflare/circl package. These functions will be used to implement asymmetric public key encryption between systems. (Currently implemented using symmetric encryption with the shared key)

Related issues

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner November 21, 2022 23:50
@calebdoxsey calebdoxsey added the enhancement New feature or request label Nov 21, 2022
@coveralls
Copy link

coveralls commented Nov 21, 2022 •
edited

Coverage Status

Coverage decreased (-0.002%) to 64.962% when pulling 9ecb792 on cdoxsey/hpke into 81053ac on main.

desimone
desimone approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question and some suggestion on more explicit error messages... feel free to disregard or keep.

pkg/hpke/url.go Outdated Show resolved Hide resolved
pkg/hpke/url.go Outdated Show resolved Hide resolved
pkg/hpke/url.go Outdated Show resolved Hide resolved
calebdoxsey and others added 4 commits November 22, 2022 10:15
@calebdoxsey @desimone
Update pkg/hpke/url.go
b49fe1c 
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
@calebdoxsey @desimone
Update pkg/hpke/url.go
53e1a12 
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
@calebdoxsey @desimone
Update pkg/hpke/url.go
941fcad 
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
@calebdoxsey
gofmt
9ecb792
@calebdoxsey calebdoxsey merged commit 9e5eaa9 into main Nov 22, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/hpke branch November 22, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @desimone