Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy: fix sign out redirect #3827

Merged
merged 2 commits into from Dec 20, 2022
Merged

proxy: fix sign out redirect #3827

merged 2 commits into from Dec 20, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

Fix the sign out redirect URL. It was pointing the dashboard path, but should be pointing to the /.pomerium/sign_out path.

Related issues

Fixes https://github.com/pomerium/internal/issues/1051

Checklist

  • reference any related issues
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Dec 19, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner December 19, 2022 21:56
@coveralls
Copy link

coveralls commented Dec 19, 2022 •
edited

Coverage Status

Coverage increased (+0.02%) to 63.044% when pulling 29d29db on cdoxsey/sign-out into c048af7 on main.

wasaga
wasaga approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@wasaga wasaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a test?

@calebdoxsey calebdoxsey merged commit 753eeff into main Dec 20, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/sign-out branch December 20, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @wasaga