Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoyconfig: clean up filter chain construction #3844

Merged
merged 6 commits into from Dec 27, 2022
Merged

envoyconfig: clean up filter chain construction #3844

merged 6 commits into from Dec 27, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

The buildFilterChains method doesn't make sense anymore. We now add all virtual hosts to all filter chains.

Related issues

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the debt Tech debt label Dec 27, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner December 27, 2022 16:14
@coveralls
Copy link

Coverage Status

Coverage: 63.154% (+0.1%) from 63.056% when pulling b2fc585 on cdoxsey/tls-cleanup into 3e892a8 on main.

@calebdoxsey calebdoxsey merged commit 67e1210 into main Dec 27, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/tls-cleanup branch December 27, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
debt Tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @desimone