postgres: return unknown records instead of skipping them #3876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of skipping unknown records, return them with a struct any of
{"id": "ID"}
.Previously when we skipped these records we inadvertently stopped a stream early if too many unknown records were returned, because the
stream.pending
list would be empty, so the code would think the stream was complete when in fact there were many more records available that would be returned by subsequent SQL calls.Related issues
Fixes https://github.com/pomerium/internal/issues/1207
Checklist
improvement
/bug
/ etc)