Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly list gRPC services accessible via the gRPC listener #3879

Merged
merged 3 commits into from Jan 11, 2023

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Jan 11, 2023

Summary

Previously, we matched all services available in the internal grpc-control-plane cluster for the external listener.
This PR changes that by limiting the available services explicitly.

Related issues

Fixes https://github.com/pomerium/internal/issues/1063
Fixes https://github.com/pomerium/internal/issues/1064

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner January 11, 2023 02:53
@coveralls
Copy link

coveralls commented Jan 11, 2023

Coverage Status

Coverage: 62.829% (+0.03%) from 62.803% when pulling 8751210 on wasaga/restrict-envoy-grpc-services into 92b5068 on main.

@wasaga wasaga merged commit 04a8281 into main Jan 11, 2023
@wasaga wasaga deleted the wasaga/restrict-envoy-grpc-services branch January 11, 2023 17:38
@wasaga wasaga added the enhancement New feature or request label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants