Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authenticate: save the session cookie with a different name #3978

Merged
merged 1 commit into from Feb 16, 2023
Merged

authenticate: save the session cookie with a different name #3978

merged 1 commit into from Feb 16, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Save the session cookie with a different name so that it doesn't collide with the proxy session cookie.

Related issues

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added bug Something isn't working backport 0-21-0 labels Feb 15, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner February 15, 2023 19:27
@coveralls
Copy link

Coverage Status

Coverage: 63.245%. Remained the same when pulling 2285da1 on cdoxsey/authenticate-separate-cookie into f2a5bda on main.

desimone
desimone approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's old is new again. We used to do this way back in <v0.4 when we stored all tokens in the authN encrypted session cookie.

@calebdoxsey calebdoxsey merged commit 3f2a3d6 into main Feb 16, 2023
@calebdoxsey calebdoxsey deleted the cdoxsey/authenticate-separate-cookie branch February 16, 2023 15:52
@backport-actions-token backport-actions-token bot mentioned this pull request Feb 16, 2023
Merged
backport-actions-token bot pushed a commit that referenced this pull request Feb 16, 2023
@calebdoxsey @github-actions
authenticate: save the session cookie with a different name (#3978)
678bae2
calebdoxsey added a commit that referenced this pull request Feb 16, 2023
@backport-actions-token @calebdoxsey
authenticate: save the session cookie with a different name (#3984)
9f54143 
authenticate: save the session cookie with a different name (#3978)

Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
backport 0-21-0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @desimone