Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authenticate: only use csrf none for apple #3979

Merged
merged 1 commit into from Feb 16, 2023
Merged

authenticate: only use csrf none for apple #3979

merged 1 commit into from Feb 16, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Typically we use SameSite=lax for the CSRF cookie. For Apple we need to use SameSite=none.

Related issues

Fixes #3972

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label Feb 15, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner February 15, 2023 21:55
@coveralls
Copy link

Coverage Status

Coverage: 63.161% (-0.08%) from 63.245% when pulling ae79bca on cdoxsey/apple-same-site into f2a5bda on main.

@calebdoxsey calebdoxsey merged commit b62efeb into main Feb 16, 2023
@calebdoxsey calebdoxsey deleted the cdoxsey/apple-same-site branch February 16, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apple: only disable CSRF Same Site for the apple identity provider
3 participants
@calebdoxsey @coveralls @desimone