Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webauthn: only return known device credentials that match the given type #3981

Merged
merged 1 commit into from Feb 16, 2023
Merged

webauthn: only return known device credentials that match the given type #3981

merged 1 commit into from Feb 16, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Currently we return all the known device credentials when generating the request options. This filters the list of device credentials to only those for the given type.

Related issues

Fixes #3909

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner February 15, 2023 23:25
@coveralls
Copy link

Coverage Status

Coverage: 63.216% (-0.03%) from 63.245% when pulling b966264 on cdoxsey/fix-authenticate-known-device-types into f2a5bda on main.

@calebdoxsey calebdoxsey merged commit b509465 into main Feb 16, 2023
@calebdoxsey calebdoxsey deleted the cdoxsey/fix-authenticate-known-device-types branch February 16, 2023 21:57
backport-actions-token bot pushed a commit that referenced this pull request Feb 16, 2023
@calebdoxsey @github-actions
webauthn: only return known device credentials that match the given t…
cbea977 
…ype (#3981)
@backport-actions-token backport-actions-token bot mentioned this pull request Feb 16, 2023
Merged
@calebdoxsey calebdoxsey mentioned this pull request Feb 16, 2023
Merged
4 tasks
calebdoxsey added a commit that referenced this pull request Feb 16, 2023
@backport-actions-token @calebdoxsey
webauthn: only return known device credentials that match the given t…
df8afa2 
…ype (#3987)

webauthn: only return known device credentials that match the given type (#3981)

Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
backport 0-21-0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-platform devices authentication allowed for enclave_only policed routes
3 participants
@calebdoxsey @coveralls @desimone