authenticate: fix identity provider id in encrypted query string #4006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
approved these changes
Feb 23, 2023
Comment on lines
+607
to
+609
| if idpID == "" { | ||
| idpID = vs.Get(urlutil.QueryIdentityProviderID) | ||
| } |
There was a problem hiding this comment.
why this clause is still required if parameter is inside hpke query?
There was a problem hiding this comment.
I think we pass the identity provider id from userinfo endpoints? I'm not totally sure. I kept it because I was afraid I'd break something by removing it.
backport-actions-token bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
Co-authored-by: Denis Mishin <dmishin@pomerium.com>
calebdoxsey
added a commit
that referenced
this pull request
Feb 23, 2023
authenticate: fix identity provider id in encrypted query string (#4006) Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com> Co-authored-by: Denis Mishin <dmishin@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per-route IDP credentials use a
pomerium_idp_idquery string parameter to indicate which credentials they need. The current code is not working because thepomerium_idp_idis inside an HPKE encrypted query string. This updates the code to decrypted the URL parameters to find it.Related issues
Fixes #3976
Checklist
improvement/bug/ etc)