Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticate: don't require a session for sign_out #4007

Merged
merged 1 commit into from Feb 23, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

The sign_out endpoint shouldn't require a session to access.

Related issues

Fixes https://github.com/pomerium/pomerium-console/issues/3103

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added bug Something isn't working backport 0-21-0 labels Feb 22, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner February 22, 2023 20:36
@coveralls
Copy link

Coverage Status

Coverage: 63.186% (-0.02%) from 63.206% when pulling e7e00da on cdoxsey/sign-out into 62ca7ff on main.

@calebdoxsey calebdoxsey merged commit be13027 into main Feb 23, 2023
@calebdoxsey calebdoxsey deleted the cdoxsey/sign-out branch February 23, 2023 04:42
backport-actions-token bot pushed a commit that referenced this pull request Feb 23, 2023
authenticate: dont require a session for sign_out
calebdoxsey added a commit that referenced this pull request Feb 23, 2023
authenticate: don't require a session for sign_out (#4007)

authenticate: dont require a session for sign_out

Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-21-0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants