authenticate: fix callback handler for split mode #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
approved these changes
Feb 23, 2023
backport-actions-token bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
fix auth handler for split mode
calebdoxsey
pushed a commit
that referenced
this pull request
Feb 23, 2023
authenticate: fix callback handler for split mode (#4008) fix auth handler for split mode Co-authored-by: Denis Mishin <dmishin@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When in split mode, authenticate service may either be exposed directly or be proxied by the
pomerium-proxyservice.This PR changes the handlers to be installed for both
authenticate_service_urlandauthenticate_internal_service_urlvirtual hosts.Related issues
Fixes https://github.com/pomerium/internal/issues/1285
User Explanation
Checklist
improvement/bug/ etc)