Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlutil: add version to query string #4028

Merged
merged 1 commit into from Feb 28, 2023
Merged

urlutil: add version to query string #4028

merged 1 commit into from Feb 28, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Add pomerium_version to the query string for sign in, sign out and the callback URL. Also move the Build...URL functions to urlutil where the other well-known URLs were being generated.

Related issues

Fixes https://github.com/pomerium/internal/issues/1281

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label Feb 28, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner February 28, 2023 18:08
@coveralls
Copy link

Coverage Status

Coverage: 63.568% (+0.2%) from 63.338% when pulling 076a5d2 on cdoxsey/pomerium-version into 78a221c on main.

@calebdoxsey calebdoxsey merged commit 2b8d51d into main Feb 28, 2023
@calebdoxsey calebdoxsey deleted the cdoxsey/pomerium-version branch February 28, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @wasaga