Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for wildcard from addresses #4131

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Adds support for from addresses like https://*.example.com.

Related issues

User Explanation

Adds support for * in from addresses that will match 0 or more characters. This can occur anywhere inside the host part of the URL.

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added docs Docs update required enhancement New feature or request labels Apr 24, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner April 24, 2023 20:49
@calebdoxsey calebdoxsey requested a review from wasaga April 24, 2023 20:49
@coveralls
Copy link

Coverage Status

Coverage: 63.727% (+0.3%) from 63.454% when pulling 3762419 on cdoxsey/wildcard-from-v2 into bbed421 on main.

@wasaga
Copy link
Contributor

wasaga commented Apr 25, 2023

the regex path option won't work with wildcard froms, correct?

@calebdoxsey
Copy link
Contributor Author

calebdoxsey commented Apr 25, 2023

The regex option will still work with wildcard froms. The route match requires all conditions to be met. So the :authority header will be matched against the wildcard from and the path will be matched against regex.

@calebdoxsey calebdoxsey merged commit 18bc86d into main Apr 25, 2023
12 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/wildcard-from-v2 branch April 25, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Docs update required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants