autocert: fix certmagic cache logging #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
approved these changes
Apr 25, 2023
calebdoxsey
added a commit
that referenced
this pull request
Apr 26, 2023
autocert: fix certmagic cache logging (#4134) Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The certmagic cache starts by using the
certmagic.Defaultconfig, which uses a default logger, so when we set it on ourcertmagic.Configit doesn't use the right logger. This updates the code so we don't useNewDefaultbut set the cache ourselves.Related issues
Fixes #4133
Checklist
improvement/bug/ etc)