Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: set re2 limits very high #4187

Merged
merged 2 commits into from May 23, 2023
Merged

envoy: set re2 limits very high #4187

merged 2 commits into from May 23, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Set the program size complexity for regular expressions in envoy to be very high.

Related issues

Fixes https://github.com/pomerium/internal/issues/1373

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added bug Something isn't working backport 0-22-0 labels May 23, 2023
@calebdoxsey calebdoxsey requested a review from a team as a code owner May 23, 2023 00:57
Copy link
Contributor

@kenjenkins kenjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't pretend to understand the Runtime configuration stuff yet, but this looks like the right idea to me.

config/envoyconfig/bootstrap_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage: 63.746% (+0.02%) from 63.726% when pulling 0bdd30b on cdoxsey/regex-limits into d6e1f3a on main.

@calebdoxsey calebdoxsey merged commit 083dbea into main May 23, 2023
13 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/regex-limits branch May 23, 2023 14:36
backport-actions-token bot pushed a commit that referenced this pull request May 23, 2023
* envoy: set re2 limits very high

* fix test
calebdoxsey added a commit that referenced this pull request May 23, 2023
envoy: set re2 limits very high (#4187)

* envoy: set re2 limits very high

* fix test

Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-22-0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants