config: simplify default set response headers #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
changed the title
kenjenkins
approved these changes
May 25, 2023
|
We have a catch-all certificate: |
desimone
approved these changes
May 26, 2023
calebdoxsey
force-pushed
the
cdoxsey/simplify-hsts
branch
from
04db439
to
3deb6b9
Compare
calebdoxsey
added a commit
that referenced
this pull request
May 31, 2023
config: simplify default set response headers (#4196) Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we selectively remove the
Strict-Transport-Securityheader for routes that use a generated certificate. This is done to help prevent the occurrence of an error page that requires users to manually typethisisunsafeto bypass.We do this by searching the entire list of certificates for any that match the route. If there are none, we assume the certificate used will be a generated one and remove the
Strict-Transport-Securityheader.This PR updates the code to instead look for any certificates at all. If at least one certificate is supplied, we will assume the user would prefer to have this header added. If none are supplied, we will assume Pomerium is running in an entirely generated mode where the inclusion of this header is more annoying than helpful.
Related issues
Checklist
improvement/bug/ etc)