Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorize: populate issuer even when policy is nil #4211

Merged
merged 1 commit into from
May 31, 2023

Conversation

kenjenkins
Copy link
Contributor

Summary

After the recent changes to internal policy evaluation, the /.pomerium/jwt endpoint was returning empty strings for the JWT aud and iss claims.

Related issues

Fixes #4210

User Explanation

Fix an issue where the /.pomerium/jwt endpoint returned a JWT missing the audience and issuer claims.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@kenjenkins kenjenkins added bug Something isn't working docs Docs update required labels May 30, 2023
@kenjenkins kenjenkins requested a review from a team as a code owner May 30, 2023 22:12
@coveralls
Copy link

Coverage Status

Coverage: 63.589% (+0.03%) from 63.561% when pulling 68736f8 on kenjenkins/jwt-claims into d315e68 on main.

@kenjenkins kenjenkins merged commit 6df4fba into main May 31, 2023
17 checks passed
@kenjenkins kenjenkins deleted the kenjenkins/jwt-claims branch May 31, 2023 00:07
@backport-actions-token
Copy link

The backport to 0-21-0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-0-21-0 0-21-0
# Navigate to the new working tree
cd .worktrees/backport-0-21-0
# Create a new branch
git switch --create backport-4211-to-0-21-0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 6df4fba83236c8401fa487c0575453b0fd759d63
# Push it to GitHub
git push --set-upstream origin backport-4211-to-0-21-0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-0-21-0

Then, create a pull request where the base branch is 0-21-0 and the compare/head branch is backport-4211-to-0-21-0.

kenjenkins added a commit that referenced this pull request May 31, 2023
authorize: populate issuer even when policy is nil (#4211)

Co-authored-by: Kenneth Jenkins <51246568+kenjenkins@users.noreply.github.com>
kenjenkins added a commit that referenced this pull request Jun 1, 2023
authorize: populate issuer even when policy is nil (#4211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-21-0 backport 0-22-0 bug Something isn't working docs Docs update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/.pomerium/jwt endpoint not setting iss and aud claims
3 participants