Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(background): improved sentence flow and other stuff #422

Merged
merged 1 commit into from Dec 12, 2019
Merged

docs(background): improved sentence flow and other stuff #422

merged 1 commit into from Dec 12, 2019

Conversation

rio
Copy link
Contributor

@rio rio commented Dec 12, 2019

Summary

Adjusted some things I noticed while reading the background.
Note that I'm dutch and not a native English speaker.

@claassistantio
Copy link

claassistantio commented Dec 12, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #422   +/-   ##
======================================
  Coverage    87.6%   87.6%           
======================================
  Files          52      52           
  Lines        2482    2482           
======================================
  Hits         2175    2175           
  Misses        241     241           
  Partials       66      66

desimone
desimone approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rio Thank you for the PR.

Note that I'm dutch and not a native English speaker.

There's got to be a joke here somewhere... it takes a dutchman to fix an American's english. 😆

@desimone desimone added the docs Docs update required label Dec 12, 2019
@desimone desimone added this to the v0.6.0 milestone Dec 12, 2019
@desimone desimone merged commit 11843c5 into pomerium:master Dec 12, 2019
@rio
Copy link
Contributor Author

rio commented Dec 12, 2019 •
edited

Didn't consider that. But if you'd see my dutch you'd realize the opposite is also true. XD

@rio rio deleted the patch-1 branch December 12, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

Assignees
No one assigned
Labels
docs Docs update required
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rio @claassistantio @desimone