ci: updates #4269
ci: updates #4269
Conversation
There was a problem hiding this comment.
Just to make sure I understand: this is fixing a warning from our recent Actions runs (e.g. https://github.com/pomerium/pomerium/actions/runs/5284751729/jobs/9562500238#step:2:16).
And we hope that better caching should allow these Actions to complete more quickly, is that right?
| - uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 | ||
| with: | ||
| go-version: ${{ matrix.go-version }} | ||
| cache: false |
There was a problem hiding this comment.
Why do we want to disable caching for this step? (Not saying we should or shouldn't, just trying to understand the impact of this setting.)
There was a problem hiding this comment.
the caches have the same keys. so we only want to cache if we're doing the full go install
| @@ -16,8 +16,6 @@ jobs: | |||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 | |||
| with: | |||
| fetch-depth: 0 | |||
There was a problem hiding this comment.
This is changing from a full clone to a shallow clone, is that right? (I find it confusing that fetch-depth: 0 means "fetch everything".)
There was a problem hiding this comment.
yes, I also didn't understand what fetch-depth: 0 did. We just copied it as we wrote everything and it was, AFAIK, only ever needed for one job
|
The time doesn't seem much faster. But it's less separate jobs anyway, so maybe we'll see some benefits when multiple PRs are running. |
Fix for this error:
Also consolidate some tasks and switch to builtin caching.