Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authorize: remove a nolint directive #4375

Merged
merged 1 commit into from Jul 19, 2023
Merged

authorize: remove a nolint directive #4375

merged 1 commit into from Jul 19, 2023

Conversation

kenjenkins
Copy link
Contributor

Summary

There's a //nolint comment in evaluator.New(). Let's update the for loop variable to avoid it.

Related issues

n/a

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@kenjenkins kenjenkins requested a review from a team as a code owner July 19, 2023 22:26
@kenjenkins kenjenkins requested a review from wasaga July 19, 2023 22:26
@coveralls
Copy link

Coverage Status

coverage: 63.389% (+0.03%) from 63.359% when pulling 3ac6cd7 on kenjenkins/evaluator-lint into 8e4f728 on main.

@kenjenkins kenjenkins merged commit 26bbcdf into main Jul 19, 2023
10 checks passed
@kenjenkins kenjenkins deleted the kenjenkins/evaluator-lint branch July 19, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenjenkins @coveralls @calebdoxsey