zero: resource bundle reconciler #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
approved these changes
Aug 17, 2023
| package reconciler | ||
|
|
||
| // RecordSetBundle is an index of databroker records by type | ||
| type RecordSetBundle[T Record[T]] map[string]RecordSet[T] |
There was a problem hiding this comment.
nit: I'm not sure why this is a generic when it's only ever used for DatabrokerRecord?
There was a problem hiding this comment.
I found it convenient to use generics for a higher level functionality like this one, as it allows writing more concise and easy to read tests compared to using the full data structure as it might be pretty large. See record_tests.go
| } | ||
|
|
||
| // MarkForSyncLater marks the bundle with the given ID for syncing later (after all other bundles). | ||
| func (b *BundleQueue) MarkForSyncLater(id string) { |
There was a problem hiding this comment.
nit: this method is O(n). If the goal of using the heap package was to achieve O(log n) performance, shouldn't all the methods be that or better? Otherwise why not just use a loop?
kenjenkins
pushed a commit
that referenced
this pull request
Nov 14, 2023
kenjenkins
pushed a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bundle Reconciler watches a group of resource bundles, downloads them and reconciles their contents with the databroker.
Bundles are not expected to have any intersection across record types.
For caching purposes, an entry with etag/last-modified is kept in the databroker, and the upload is conditional. That way, there's no need to keep a cache of downloaded bundles.
Related issues
Implements https://github.com/pomerium/internal/issues/1423
User Explanation
Checklist
improvement/bug/ etc)