Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry package #4458

Merged
merged 2 commits into from
Aug 16, 2023
Merged

add retry package #4458

merged 2 commits into from
Aug 16, 2023

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Aug 13, 2023

Summary

Adds retry package that performs exponential backoff retry for a given function,
while also monitoring multiple channels with possible side effect functions.

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga marked this pull request as ready for review August 16, 2023 01:02
@wasaga wasaga requested a review from a team as a code owner August 16, 2023 01:02
@wasaga wasaga requested review from kenjenkins and calebdoxsey and removed request for a team August 16, 2023 01:02
Copy link
Contributor

@calebdoxsey calebdoxsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to include unrelated changes.

Copy link
Contributor

@calebdoxsey calebdoxsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code related to reflection on channels is too complex for me to understand and I don't understand how or why to use this package but I didn't see anything to comment on.

@wasaga
Copy link
Contributor Author

wasaga commented Aug 16, 2023

The code related to reflection on channels is too complex for me to understand and I don't understand how or why to use this package

It was factored out of two other PRs, as otherwise their retry / signalling logic was awfully complicated and the control loop impossible to test in isolation.

@wasaga wasaga merged commit 65c0f6b into feature/zero Aug 16, 2023
9 checks passed
@wasaga wasaga deleted the wasaga/zero-retry branch August 16, 2023 16:45
kenjenkins pushed a commit that referenced this pull request Nov 14, 2023
kenjenkins pushed a commit that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants