config: deprecate tls_downstream_client_ca #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log a deprecation warning for any route where tls_downstream_client_ca or tls_downstream_client_ca_file is non-empty.
calebdoxsey
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Log a deprecation warning for any route where
tls_downstream_client_caortls_downstream_client_ca_fileis non-empty, with a link to the reference page for this setting (the deprecation warning still needs to be added to the documentation, see pomerium/documentation#913).Related issues
#4356
User Explanation
The
tls_downstream_client_caandtls_downstream_client_ca_fileroute options are deprecated, and will be removed in a future Pomerium release.Checklist
improvement/bug/ etc)