core/authenticate: validate the identity profile #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
reviewed
Sep 15, 2023
| } | ||
|
|
||
| if !oauthToken.Valid() { | ||
| return fmt.Errorf("invalid oauth token in profile") |
There was a problem hiding this comment.
can AccessToken be missing or it's just expiration condition?
There was a problem hiding this comment.
I don't think it can be missing, but I'm not sure.
wasaga
approved these changes
Sep 15, 2023
calebdoxsey
added a commit
that referenced
this pull request
Sep 15, 2023
core/authenticate: validate the identity profile (#4545) Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validate the identity profile by checking that the oauth token is still valid and calling the user info endpoint. If the access token has been revoked that call should fail and the identity profile will be treated as if it doesn't exist. This will then trigger the re-authentication flow.
Related issues
Checklist
improvement/bug/ etc)