Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/controlplane: apply configuration changes in a background thread #4649

Merged
merged 3 commits into from Oct 31, 2023
Merged

core/controlplane: apply configuration changes in a background thread #4649

merged 3 commits into from Oct 31, 2023

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Oct 30, 2023 •
edited

Summary

Some performance improvements. Mostly trying to utilize more cores by running more goroutines.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@coveralls
Copy link

coveralls commented Oct 30, 2023 •
edited

Coverage Status

coverage: 63.932% (-0.01%) from 63.943% when pulling 8cf3b1f on cdoxsey/performance-improvements into 2472490 on main.

@calebdoxsey calebdoxsey marked this pull request as ready for review October 30, 2023 21:28
@calebdoxsey calebdoxsey requested a review from a team as a code owner October 30, 2023 21:28
wasaga
wasaga approved these changes Oct 31, 2023
View reviewed changes
internal/controlplane/server.go
res, err := srv.buildDiscoveryResources(ctx)
if err != nil {
return err
select {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a trace here to see how long do we spend

@calebdoxsey calebdoxsey merged commit 6511440 into main Oct 31, 2023
9 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/performance-improvements branch October 31, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @wasaga