core/hpke: reduce memory usage from zstd #4650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on https://pkg.go.dev/tailscale.com/smallzstd we can use a smaller window size and some options to reduce the memory usage for zstd.
Re-using the encoder and decoder appears to be supported based on the packages documentation. The defaults are not a memory leak, but they do use a lot of memory since they are optimized for large payloads.
Related issues
Checklist
improvement
/bug
/ etc)