databroker: build config concurrently, option to bypass validation #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
changed the title
wasaga
commented
Nov 2, 2023
| @@ -40,7 +40,7 @@ func Run(ctx context.Context, src config.Source) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| src = databroker.NewConfigSource(ctx, src) | |||
| src = databroker.NewConfigSource(ctx, src, databroker.EnableConfigValidation(true)) | |||
There was a problem hiding this comment.
this one is to keep current behaviour for now
wasaga
commented
Nov 2, 2023
| if err != nil { | ||
| metrics.SetDBConfigRejected(ctx, cfg.Options.Services, id, cfgpb.version, err) |
There was a problem hiding this comment.
those metrics were originally added for console, however they are not compatible with chunked config anyway currently, thus removing them for now as they require redesign.
calebdoxsey
reviewed
Nov 2, 2023
calebdoxsey
reviewed
Nov 2, 2023
calebdoxsey
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
User Explanation
Checklist
improvement/bug/ etc)