Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: add type url to log #4696

Merged
merged 1 commit into from Nov 1, 2023
Merged

xds: add type url to log #4696

merged 1 commit into from Nov 1, 2023

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Nov 1, 2023

Summary

Adds type-url to XDS logs so that it would be clearer which resource types are updated.

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner November 1, 2023 16:41
@wasaga wasaga added backport 0-23-0 enhancement New feature or request labels Nov 1, 2023
@coveralls
Copy link

Coverage Status

coverage: 64.008% (-0.007%) from 64.015% when pulling df9f814 on wasaga/add-xds-type-url into 53573dc on main.

@wasaga wasaga merged commit 0b79a28 into main Nov 1, 2023
11 checks passed
@wasaga wasaga deleted the wasaga/add-xds-type-url branch November 1, 2023 20:51
@backport-actions-token
Copy link

The backport to 0-23-0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-0-23-0 0-23-0
# Navigate to the new working tree
cd .worktrees/backport-0-23-0
# Create a new branch
git switch --create backport-4696-to-0-23-0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0b79a2832880dd9f235c4088dc55791545f72ed1
# Push it to GitHub
git push --set-upstream origin backport-4696-to-0-23-0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-0-23-0

Then, create a pull request where the base branch is 0-23-0 and the compare/head branch is backport-4696-to-0-23-0.

@wasaga wasaga removed the enhancement New feature or request label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants