databroker: add utility recordset and changeset #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
reviewed
Nov 3, 2023
calebdoxsey
approved these changes
Nov 3, 2023
kenjenkins
reviewed
Nov 3, 2023
| } | ||
| } | ||
|
|
||
| // Remove adds a record to the change set. |
There was a problem hiding this comment.
I find this a little confusing, maybe we could rephrase it something like this?
Suggested change
| // Remove adds a record to the change set. | |
| // Remove adds a record to the change set, marked for deletion. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds utility functions to calculate the difference between observed and derived state of databroker. Used by the console and zero managed mode.
Related issues
User Explanation
Checklist
improvement/bug/ etc)