Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/config: remove unnecessary authenticate route #4719

Merged
merged 1 commit into from Nov 8, 2023
Merged

core/config: remove unnecessary authenticate route #4719

merged 1 commit into from Nov 8, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

If we're using the default authenticate.pomerium.app authenticate URL, don't add a route to envoy.

Related issues

Fixes https://github.com/pomerium/internal/issues/1416

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner November 7, 2023 23:02
@coveralls
Copy link

Coverage Status

coverage: 63.701% (-0.01%) from 63.712%
when pulling cd61532 on cdoxsey/authenticate-route
into ffca3b3 on main.

@calebdoxsey calebdoxsey merged commit 77f9893 into main Nov 8, 2023
10 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/authenticate-route branch November 8, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjenkins kenjenkins kenjenkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @kenjenkins