Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/config: add pass_identity_headers option #4720

Merged
merged 3 commits into from Nov 8, 2023
Merged

core/config: add pass_identity_headers option #4720

merged 3 commits into from Nov 8, 2023

Conversation

calebdoxsey
Copy link
Contributor

Summary

Add a global config option for pass_identity_headers.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner November 7, 2023 23:34
@coveralls
Copy link

coveralls commented Nov 7, 2023 •
edited

Coverage Status

coverage: 63.705% (-0.007%) from 63.712%
when pulling e98d5d7 on cdoxsey/config-option-pass-identity-headers
into ffca3b3 on main.

kenjenkins
kenjenkins reviewed Nov 8, 2023
View reviewed changes
pkg/grpc/config/config.proto Show resolved Hide resolved
pkg/grpc/config/config.proto Outdated Show resolved Hide resolved
kenjenkins
kenjenkins approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@kenjenkins kenjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@calebdoxsey calebdoxsey merged commit 3bdbd56 into main Nov 8, 2023
9 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/config-option-pass-identity-headers branch November 8, 2023 20:07
calebdoxsey added a commit that referenced this pull request Nov 8, 2023
@calebdoxsey
Revert "core/config: add pass_identity_headers option (#4720)"
817720c 
This reverts commit 3bdbd56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjenkins kenjenkins kenjenkins approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @kenjenkins