core/storage: fix nil data unmarshal #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
approved these changes
Nov 10, 2023
calebdoxsey
added a commit
that referenced
this pull request
Nov 10, 2023
core/storage: fix nil data unmarshal (#4734) Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When deleting a record it's possible to set
datato be nil. In that case the row would be removed from therecordstable, but there would be an entry in therecord_changestable withnildata. The call to stream changes would then attempt to convert this row into a record and fail with an error. This PR updates the code to tolerate nil data.Any consuming code would also need to tolerate nil data accordingly. Whether that's the case or not for all known usages is unclear.
Related issues
Fixes #4733
Checklist
improvement/bug/ etc)