databroker: changeset: prevent nil data in the deleted records #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
reviewed
Nov 10, 2023
| @@ -37,6 +38,7 @@ func (cs *changeSet) Remove(typ string, id string) { | |||
| Type: typ, | |||
| Id: id, | |||
| DeletedAt: cs.now, | |||
| Data: &anypb.Any{TypeUrl: typ}, | |||
There was a problem hiding this comment.
I'm not sure what this will do. The data would be nil. It may fail in marshaling and/or unmarshaling.
There was a problem hiding this comment.
Apparently it's fine 🤷 .
calebdoxsey
approved these changes
Nov 10, 2023
wasaga
added a commit
that referenced
this pull request
Nov 10, 2023
databroker: changeset: prevent nil data in the deleted records (#4736) Co-authored-by: Denis Mishin <dmishin@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents
Record.Databeingnilin the deleted records, by setting it to emptyprotobuf.Anyof desired type.Related issues
Related: #4733
User Explanation
Checklist
improvement/bug/ etc)