Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero/bundle-reconciler: better code reuse #4758

Merged
merged 1 commit into from Nov 21, 2023
Merged

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Nov 21, 2023

Summary

Previously reconciler code from internal/zero was generalized for pkg/grpc/databroker, but original zero packages were
not updated. This PR fixes that.

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner November 21, 2023 04:00
@coveralls
Copy link

Coverage Status

coverage: 62.562% (-0.4%) from 62.947%
when pulling 0ea36cc on wasaga/reconciler-code-reuse
into 14b13bb on main.

@wasaga wasaga merged commit 7e2532f into main Nov 21, 2023
9 checks passed
@wasaga wasaga deleted the wasaga/reconciler-code-reuse branch November 21, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants