core/go: use max procs #4766
Merged
core/go: use max procs #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjenkins
approved these changes
Nov 28, 2023
| @@ -20,7 +20,7 @@ func Build[T any]( | |||
| builders ...BuilderFunc[T], | |||
| ) ([]*T, []error) { | |||
| eg, ctx := errgroup.WithContext(ctx) | |||
| eg.SetLimit(runtime.NumCPU()/2 + 1) | |||
| eg.SetLimit(runtime.GOMAXPROCS(0)/2 + 1) | |||
There was a problem hiding this comment.
Should this consider both GOMAXPROCS and NumCPU, and base the limit on whichever is lower?
There was a problem hiding this comment.
I'm not sure what the purpose of this was. It sounds like it was put in place to avoid CPU starvation, but Go has had a pre-emptive scheduler for a while now, so starvation shouldn't be an issue.
@wasaga what do you think it should do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
automaxprocsto setGOMAXPROCSto the cgroup limits for containers. Also useGOMAXPROCSinstead ofruntime.NumCPU.Related issues
Checklist
improvement/bug/ etc)